-
-
Notifications
You must be signed in to change notification settings - Fork 963
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial ScottPlotExporter with just Bar Plot and Unit Tests #2560
Conversation
tests/BenchmarkDotNet.Exporters.Plotting.Tests/BenchmarkDotNet.Exporters.Plotting.Tests.csproj
Show resolved
Hide resolved
tests/BenchmarkDotNet.Exporters.Plotting.Tests/BenchmarkDotNet.Exporters.Plotting.Tests.csproj
Outdated
Show resolved
Hide resolved
tests/BenchmarkDotNet.Exporters.Plotting.Tests/BenchmarkDotNet.Exporters.Plotting.Tests.csproj
Outdated
Show resolved
Hide resolved
@dotnet-policy-service agree |
src/BenchmarkDotNet.Exporters.Plotting/BenchmarkDotNet.Exporters.Plotting.csproj
Outdated
Show resolved
Hide resolved
src/BenchmarkDotNet.Exporters.Plotting/BenchmarkDotNet.Exporters.Plotting.csproj
Outdated
Show resolved
Hide resolved
tests/BenchmarkDotNet.Exporters.Plotting.Tests/BenchmarkDotNet.Exporters.Plotting.Tests.csproj
Outdated
Show resolved
Hide resolved
tests/BenchmarkDotNet.Exporters.Plotting.Tests/BenchmarkDotNet.Exporters.Plotting.Tests.csproj
Outdated
Show resolved
Hide resolved
….Exporters.Plotting.Tests.csproj
Hey @timcassell and @AndreyAkinshin just checking in for a status update on this one. I'm happy for any feedback. My plan was to add the rest of the charts that the R plot has once this PR was accepted. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but @AndreyAkinshin controls the Nuget packages, so he'll need to approve this and get it on Nuget.
@FlatlinerDOA thanks! |
I have been trying out this new ScottPlotExporter but getting some weird results. Perhaps I am using it wrong? var exporter = new ScottPlotExporter();
var logger = new AccumulationLogger();
var summaries = BenchmarkSwitcher.FromAssembly(Assembly.GetExecutingAssembly()).Run(args);
foreach (var summary in summaries)
{
var filePaths = exporter.ExportToFiles(summary, logger).ToList();
WriteLine(string.Join(Environment.NewLine, filePaths));
}
|
@FlatlinerDOA not sure I fully follow given what I show is way off from plot, e. g. PlainStruct has mean +170 ns but nothing in plot is anywhere near that, all values around 10-12ns... that is they are much lower. |
This adds a new project called BenchmarkDotNet.Exporters.Plotting.
Currently just supports Bar Plots with configurable options for Width, Height and whether to RotateLabels (for large bar labels defaults to true).
Example Bar Plot:
NOTE: Currently build gets an error about strong naming?